After Contributors make changes in a branch, they submit a Pull Request for review by the Approver. The Approver (or Owner) reviews each change and either approves or rejects them. To manage this process, Approvers use the Branch Details' Pull Request page. The Pull Request page provides information on the Pull Request submission, a list of modules submitted in the Pull Request, and the Pull Request's activity history.
Accessing the Branch Details' Pull Request Page
Approvers use the Branch Details page to review, approve, or reject changes submitted in a Pull Request. From this page, Approvers can also access the View Diffs tool for modules branched from the main module.
To access the Pull Request page on the Workspaces page:
From the Workspaces view, select a workspace tile.
Locate a VCS-enabled application. The VCS icon displays in the tile's header.
Click the application tile's name, or click View App in VCS.
(click image to enlarge)
If required, enter your UDLC credentials to log into the VCS tool. The App Details' Branches page displays.
From the Branches I Created drop-down, select My 'Approver' Branches.
NOTE Creators must be assigned a role in a branch to see it in the Branches list. The branch Owner can add Creators to roles in a branch by editing the branch settings.
Click Search. The Branches list displays branches to which you have Approver access.
Select the name of a branch that is Pending Review. The Branch Details' Modules page displays.
Click Pull Request.
NOTE The Pull Request page is not accessible if the branch doesn't have a previous or current Pull Request.
Approving or Rejecting Changes
Modules created or marked for deletion in a branch do not require the Approver to compare differences like a branched module. To review new modules or modules marked for deletion, use the Branch Details Modules page.
To approve or reject changes from the Pull Request page:
From the Modules to Review list, find a module that offers the Approve | Reject buttons.
NOTE The Approve and Reject buttons do not display for modules experiencing conflicts, or if they have changes that must first be reviewed.
Click Approve or Reject. The decision displays in the Approver Decision column.
Reviewing Branched Main Module Changes
If the Pull Request contains modules that are branched from the main Module, the Approver uses the View Diff tool to review the changes. The View Diff tool displays a list of changes made to a module and visually compares those changes in a side-by-side display.
To review a branched main module from the Pull Request page:
Under Modules to Review, navigate to a branch module with the View Diffs button in the Actions column.
Click View Diffs. The View Diffs page displays the branch module.
Component changes in a module display under the Components (x) tab. From this tab, review the changes in each component using the Main Module and Branch Module comparison windows.
NOTE The x in Components (x) represents the total value of component changes in the module. This value matches the amount of rows in the Changes in Branch Module list.
Under the Changes in the Branch Module list, next to a component requiring review, click Find. The Main Module and Branch Module comparison windows refresh, outlining the component changes.
In the comparison view, review changes to the component and open its configuration settings. The Main Module window displays the current state of the Main Branch.and The Branch Module window displays the changes created in the branch.
Repeat this process until all changes are reviewed.
If no issues are found, click ✓ Approve to mark the branch module as ready to merge.
(Optional) If an issue is found during the review, click the X Reject button.
Approving or Rejecting a Pull Request
Once an Approver reviews all changes submitted in a Pull Request, they can approve or reject it. Approving a Pull Request indicates it is ready for merge by the Owner. Rejecting a Pull Request indicates the branch needs further changes before it is submitted using another Pull Request
Approving a Pull Request
If all changes in a Pull Request are approved, the Approve Pull Request button becomes available to use. Approving a Pull Request notifies participants (with notifications enabled) that the branch is approved and ready to be merged by the Owner.
After all changes are approved in the Pull Request: